Release 1.32.0 doc changes #102
Conversation
✅ Deploy Preview for nginx-unit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Is there some missing commits? or is that the more to come? |
There is more to come. We are currently working on the commits. |
|
A couple of issues I see here
I think we should stick to keeping our lines < 80 characters wide where possible, obviously commands, URL's etc should not be wrapped.
These patches introduce a fair amount of excess whitespace $ git diff --check master.. | grep -v ^+ # because the highlighted whitespace won't show here
source/configuration.rst:5137: trailing whitespace.
source/configuration.rst:5140: trailing whitespace.
source/configuration.rst:5141: trailing whitespace.
source/configuration.rst:5149: trailing whitespace.
source/configuration.rst:5150: trailing whitespace.
source/configuration.rst:5152: trailing whitespace.
source/configuration.rst:5153: trailing whitespace.
source/configuration.rst:5154: trailing whitespace.
source/configuration.rst:5163: trailing whitespace.
source/configuration.rst:5167: trailing whitespace.
source/configuration.rst:5168: trailing whitespace.
source/configuration.rst:5169: trailing whitespace.
source/configuration.rst:5171: trailing whitespace.
source/configuration.rst:5172: trailing whitespace.
source/configuration.rst:5177: trailing whitespace.
source/configuration.rst:5183: trailing whitespace.
source/configuration.rst:5189: trailing whitespace.
source/configuration.rst:5197: trailing whitespace.
source/configuration.rst:5282: trailing whitespace.
source/configuration.rst:5287: trailing whitespace.
source/configuration.rst:5288: trailing whitespace.
source/configuration.rst:5290: trailing whitespace.
source/configuration.rst:5291: trailing whitespace.
source/howto/source.rst:155: trailing whitespace.
source/howto/source.rst:158: trailing whitespace.
source/howto/source.rst:178: trailing whitespace.
source/howto/source.rst:180: trailing whitespace.
source/howto/source.rst:184: trailing whitespace.
source/howto/source.rst:187: trailing whitespace.
source/howto/source.rst:190: trailing whitespace.
source/howto/source.rst:192: trailing whitespace.
source/howto/source.rst:194: trailing whitespace.
source/howto/source.rst:196: trailing whitespace.
source/howto/source.rst:198: trailing whitespace.
source/howto/source.rst:200: trailing whitespace.
source/howto/source.rst:201: trailing whitespace.
source/howto/source.rst:744: trailing whitespace.
source/news/2024/index.rst:9: trailing whitespace.
source/news/2024/unit-1.32.0-released.rst:15: trailing whitespace.
source/news/2024/unit-1.32.0-released.rst:27: trailing whitespace.
source/news/2024/unit-1.32.0-released.rst:29: trailing whitespace.
source/news/2024/unit-1.32.0-released.rst:47: trailing whitespace.
source/news/2024/unit-1.32.0-released.rst:55: trailing whitespace. |
|
White space issue can be fixed via |
Trailing spaces slipped in when moving content from Confluence I will resolved those. Line length is not an issue in my book. We don't enforce in any doc repos. We disable the checks in linter. We can discuss it and make a decision. |
Co-authored-by: Liam Crilly <liam.crilly@nginx.com>
|
@lcrilly I responded to that over in #110 (comment) if you'd like to consider my rationale here |
Co-authored-by: Dan Callahan <d.callahan@f5.com>
Co-authored-by: Liam Crilly <liam.crilly@nginx.com>
Release 1.32 rewrite news doc
Release 1.32.0 branch
Adds all the documentation changes related to Unit Release 1.32.0
Planned changes:
This PR is a work in progress. The planned changes above will be updated as we go.